Add retries to the end-2-end tests. #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new retries work, in this run, the smudge test would have crashed the pipeline. Instead it was re-run, worked, and the pipeline passed. closes #249 |
craffel
approved these changes
May 10, 2024
This PR adds the ability to do a limited number of retries (3) for end2end tests. Often the windows tests will fail during CI (an error about the event loop being closed) crashing the whole end2end ci pipeline. As these are flaky, not broken, re-running the failed tests often fixes the problem. But this is annoying to have to get and email and click re-run each time it happens. This new version will rerun failed tests automatically, logging when a test that passed needed multiple tires. Hopefully this makes the windows issue less annoying going forward.
blester125
force-pushed
the
chore/rerun-tests
branch
from
89affb7 to
c6b6a8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to do a limited number of retries (3) for end2end tests. Often the windows tests will fail during CI (an error about the event loop being closed) crashing the whole end2end ci pipeline.
As these are flaky, not broken, re-running the failed tests often fixes the problem. But this is annoying to have to get and email and click re-run each time it happens. This new version will rerun failed tests automatically, logging when a test that passed needed multiple tires. Hopefully this makes the windows issue less annoying going forward.
Related to #249, need to verify the retries work/make windows more reliable before we close it.